Add fix for Start-Job initialization script in system lockdown#8284
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Nov 26, 2018
PaulHigin:fix_startjob_initScript
Merged
Add fix for Start-Job initialization script in system lockdown#8284adityapatwardhan merged 2 commits intoPowerShell:masterfrom PaulHigin:fix_startjob_initScript
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
PaulHigin:fix_startjob_initScript
Conversation
TravisEz13
approved these changes
Nov 16, 2018
adityapatwardhan
approved these changes
Nov 19, 2018
Member
|
@PaulHigin, could you push a commit with |
Member
|
Restarted CI in appveyor to pickup the latest test fixes. |
Contributor
Author
|
@adityapatwardhan Can this be merged? |
iSazonov
pushed a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
…as trusted in system lockdown (PowerShell#8284)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a Windows platform issue only.
When running remote initialization script, the script block is considered internal and marked as trusted. In system lock down mode, PowerShell runs in ConstrainedLanguage mode and won't allow a trusted script block to run in the default scope.
Fix is to mark the initialization script as untrusted external when system is locked down.
Repro:
Fix is to mark initialization script as untrusted "external origin" when system is in lock down mode, so that it can run in ConstrainedLanguage session scope.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests