Token calculation fix for Get-Help executed on ScriptBlock.#8238
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Nov 20, 2018
hubuk:issue8234
Merged
Token calculation fix for Get-Help executed on ScriptBlock.#8238adityapatwardhan merged 2 commits intoPowerShell:masterfrom hubuk:issue8234
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
hubuk:issue8234
Conversation
adityapatwardhan
approved these changes
Nov 19, 2018
Member
|
@hubuk I have pushed a commit with The new test is part of a |
Contributor
Author
|
Thanks, I can add [Feature] prefix to the message in my commit. Would you like me to do it instead and rebase my commit? |
Member
|
@hubuk Don't worry about rebasing. I pushed an empty commit with I have restarted the CI on AppVeyor to pick up the fixes for the unrelated failing test. |
Member
|
@hubuk Thank you for your contribution! |
iSazonov
pushed a commit
to iSazonov/PowerShell
that referenced
this pull request
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #8234
PR Summary
Changed token calculation for Get-Help cmdlet.
Added test case for function dynamically created from script block.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests