Skip to content

Add title to Open Here window for MSI installer#8164

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:open-here-title
Nov 1, 2018
Merged

Add title to Open Here window for MSI installer#8164
TravisEz13 merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:open-here-title

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Nov 1, 2018 •
edited
Loading

PR Summary

Since we don't explicitly set the window title, it just shows the path to pwsh.exe. Fix is to use the -Command parameter to set the window title.

Fix #8163

PR Checklist

[package]
8565f41 
add title to Open Here window
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 1, 2018

There is a related issue #7991

@TravisEz13 TravisEz13 merged commit eaa6831 into PowerShell:master Nov 1, 2018
@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jan 17, 2019
@SteveL-MSFT SteveL-MSFT deleted the open-here-title branch March 10, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@anmenaga anmenaga anmenaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PowerShell does not set the terminal window title when opened via directory context menu

4 participants

@SteveL-MSFT @iSazonov @TravisEz13 @anmenaga

Comments