Publish test package at AGENT_WORKFOLDER if TEMP is not available#8108
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Oct 23, 2018
Merged
Conversation
JamesWTruher
approved these changes
Oct 23, 2018
Collaborator
JamesWTruher
left a comment
There was a problem hiding this comment.
just one comment, and not a blocker in this case
PaulHigin
approved these changes
Oct 23, 2018
| $rootFolder = $env:AGENT_WORKFOLDER | ||
| } | ||
|
|
||
| $packageRoot = Join-Path $rootFolder ('TestPackage-' + (new-guid)) |
Contributor
There was a problem hiding this comment.
Is it possible to have both $env:Temp and $env:TF_BUILD be null? Maybe we should have a Test-Path here and throw an error message ... "package path cannot be found"?
Member
Author
There was a problem hiding this comment.
$env:TEMP should be set in most cases. VSTS macOS hosts seem to be the only place where it is not set. $env:TF_BUILD is always set in VSTS builds. I will keep this as is for now. If we see problems we can address them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
macOS hosted agents on Azure DevOps do not have
$env:TEMPset. In that case, use$env:AGENT_WORKFOLDERPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests