Skip to content

Add Linux ARM64 build support#8016

Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
slide:master
Dec 5, 2018
Merged

Add Linux ARM64 build support#8016
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
slide:master

Conversation

@slide
Copy link
Contributor

@slide slide commented Oct 12, 2018

PR Summary

This adds an additional flag to allow building for linux-arm64.

PR Checklist

  • [PR has a meaningful title]
  • [Summarized changes]
  • [Change is not breaking]
  • [Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header]
  • This PR is ready to merge and is not [Work in Progress]
  • User-facing changes
    • Not Applicable
  • Testing - New and feature
    • Not Applicable or can only be tested interactively

@slide slide mentioned this pull request Oct 12, 2018
Closed
@slide
Copy link
Contributor Author

slide commented Oct 12, 2018

Related to #7330

@TravisEz13 TravisEz13 added WG-Maintainers-Build specific to affecting the build Documentation Needed in this repo Documentation is needed in this repo labels Oct 12, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Oct 12, 2018

@slide Did you do any testing of the build?

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 12, 2018

Is ARM64 also Raspbian? Should we update this doc to say both architectures of Raspbian?
https://docs.microsoft.com/en-us/powershell/scripting/powershell-core-support?view=powershell-6

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 12, 2018 •
edited
Loading

You also need to do some work if you want us to release a package (you could just file an issue for this, if that wasn't your intent.)

The packaging module needs to be updated to be able to package TarArm64

PowerShell/tools/packaging/packaging.psm1

Line 68 in 81b67c9

} elseif ($Type -eq "tar-arm") {

PowerShell/tools/releaseBuild/Images/GenericLinuxFiles/PowerShellPackage.ps1

Line 57 in 81b67c9

if ($TarArm) {

Needs to be updated with a TarArm64 option

And it needs to be called here:

PowerShell/tools/releaseBuild/build.json

Line 264 in 81b67c9

"BuildCommand": "/PowerShellPackage.ps1 -location _RepoDestinationPath_ -destination _DockerVolume_ -ReleaseTag _ReleaseTag_ -TarX64 -TarArm",

@slide
Copy link
Contributor Author

slide commented Oct 13, 2018

Yes, I tested on my RockPro64 board. I was using it to build ironpython on that board. I will also update the packaging, I was looking for that and didn't know where it was.

@slide
Copy link
Contributor Author

slide commented Oct 13, 2018

My board is running Ubuntu 18.04 Bionic, not Raspian.

@slide
Copy link
Contributor Author

slide commented Oct 13, 2018

How do I run the packaging stuff locally to test it out?

@TravisEz13
Copy link
Member

TravisEz13 commented Oct 13, 2018 •
edited
Loading

run start-psbuild -configuration 'release' -crossgen -psmodulerestore
then import the packaging module Import-module .\tools\packaging -force
then run packaging start-pspackaging -Type tar-arm64

I did this from memory and start-pspackaging might tell you, that you need to skip release checks... It's fine to do that for development.

If you only change the packaging code, you can just re-import the packaging module, and rerun the packaging step (this is why I separated the modules.)

@joeyaiello joeyaiello mentioned this pull request Oct 15, 2018
Closed
@joeyaiello joeyaiello removed Documentation Needed in this repo Documentation is needed in this repo labels Oct 15, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 1, 2018

@slide What is status of the PR? Do you want to continue?

@slide
Copy link
Contributor Author

slide commented Nov 1, 2018

Yes, I do, I just need to get back to it again. I'll try and do it this next week.

@slide slide requested a review from PaulHigin as a code owner November 8, 2018 12:12
@TravisEz13
Copy link
Member

TravisEz13 commented Nov 13, 2018

restarted linux CI due to a connectivity issue

@slide
Copy link
Contributor Author

slide commented Nov 13, 2018

I do still plan on getting back to this, if it needs to be closed for now for some reason, I can reopen at a later date if desired.

@slide
Copy link
Contributor Author

slide commented Dec 3, 2018

I will not have time to get back to this for some time. Trying to get a local build of the package stuff has not been easy.

@slide slide closed this Dec 3, 2018
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Dec 4, 2018

@slide Thanks for starting this, I'll submit a new PR with the packaging work along with the changes you've made for the build

@SteveL-MSFT SteveL-MSFT reopened this Dec 4, 2018
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Dec 4, 2018

I'll just re-use this PR

@SteveL-MSFT SteveL-MSFT added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Dec 4, 2018
@SteveL-MSFT
[package]
d22bd92 
update packaging to support tar-arm64
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Dec 4, 2018

@SteveL-MSFT - You need to add items suggest by comment #8016 (comment)

@SteveL-MSFT
[package]
5c05b80 
address Travis' feedback
@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Dec 4, 2018

@adityapatwardhan latest commit should address the rest of @TravisEz13 's feedback

@adityapatwardhan adityapatwardhan merged commit 74de391 into PowerShell:master Dec 5, 2018
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Dec 5, 2018

@slide Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log WG-Maintainers-Build specific to affecting the build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slide @TravisEz13 @iSazonov @SteveL-MSFT @adityapatwardhan @joeyaiello

Comments