Conversation
SteveL-MSFT
previously requested changes
Oct 9, 2018
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
I don't believe this PR provides much value. The current content is fine.
|
@SteveL-MSFT I actually think that PR provides more value than what is listed in the 'Files changes'. Something we discussed previously. |
Contributor
|
I think this is the only one that makes more sense:
|
anmenaga
approved these changes
Oct 11, 2018
TravisEz13
approved these changes
Oct 19, 2018
| @@ -194,7 +194,7 @@ To make things easy, you can just clone recursively: | |||
| git clone --recursive https://github.com/PowerShell/PowerShell.git | |||
Member
There was a problem hiding this comment.
--recursive is not needed anymore.
Do you want to fix this or merge as is?
Member
There was a problem hiding this comment.
I would like this to be removed as --recursive is not needed anymore.
Member
|
@IgoTenz Please fill the PR template above, it helps us create change logs. |
Collaborator
|
@adityapatwardhan I updated the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Simple grammatical correction in README.md file.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests