Allow dynamic parameter to be returned for Get-Content even if path matches nothing to get correct error#7957
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Oct 18, 2018
Conversation
iSazonov
approved these changes
Oct 6, 2018
anmenaga
approved these changes
Oct 10, 2018
adityapatwardhan
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Get-Contentworks against a provider (which is currently only supported by filesystemprovider). In the case of dynamic parameters,Get-Contentuses globbing to get the appropriate provider to request dynamic parameters. Previously, after globbing it would use the first resolved path to obtain the dynamic parameter and if globbing returned nothing, it would not request the dynamic parameter from the provider. This results in confusing errors to the user reporting that-Rawis not valid, when it is.The fix is to let the provider decide what to do with the given path when obtaining the dynamic parameters. In the case of the filesystem provider, it doesn't even use the path.
Fix #6954
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests