remove badges for master build as it reflects last PR#7816
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Sep 19, 2018
Merged
remove badges for master build as it reflects last PR#7816TravisEz13 merged 1 commit intoPowerShell:masterfrom
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
TravisEz13
approved these changes
Sep 18, 2018
Member
|
#7817 will workaround the failure in linux CI |
…tionable from the README file
2235b6c to
dd9cef6
Compare
Member
|
I rebased tho branch to pickup the CI fix from #7817 |
Contributor
|
@SteveL-MSFT this PR left a few orphan link definitions, e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The current README.md has badges showing the status of build of master branch, but this reflects the last submitted PR which is temporal. Depending on when you load the page, someone could have a broken build in an un-merged PR. This is not actionable from the README.md as the PR submitted would be fixing it in their PR. This row of badges is more confusing than helpful.
Fix is to remove that row of badges. Only the nightly badges are useful which are post PR merges.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests