Skip to content

Update PSReadLine to 2.0.0-beta3#7711

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:psreadline-beta3
Sep 5, 2018
Merged

Update PSReadLine to 2.0.0-beta3#7711
TravisEz13 merged 1 commit intoPowerShell:masterfrom
SteveL-MSFT:psreadline-beta3

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Sep 5, 2018

PR Summary

Update PSReadLine shipped with PSCore6 to 2.0.0-beta3

cc @edyoung @jianyunt

PR Checklist

Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a common pattern:
A dependency package releases a new version, and in-response every time we have to: 1) learn about it 2) manually update our stuff by a PR like this one.
I'm curios if (at least) the discovery part can be automated...

@anmenaga
Copy link

anmenaga commented Sep 5, 2018

I've restarted failed 'PowerShell-CI-macos'.

@SteveL-MSFT
Copy link
Member Author

@anmenaga in this particular case, I worked with Jason to publish beta3. I agree that we could have some automation to detect new versions were published and we can decide if we should move to it.

@TravisEz13 TravisEz13 merged commit 70d6015 into PowerShell:master Sep 5, 2018
@iSazonov
Copy link
Collaborator

iSazonov commented Sep 6, 2018

@anmenaga @SteveL-MSFT We already have #7661.

TravisEz13 pushed a commit that referenced this pull request Sep 7, 2018
Update PSReadLine shipped with PSCore6 to 2.0.0-beta3
@TravisEz13 TravisEz13 added this to the v6.1.0 milestone Sep 7, 2018
@felixfbecker
Copy link
Contributor

This seems to be a common pattern:
A dependency package releases a new version, and in-response every time we have to: 1) learn about it 2) manually update our stuff by a PR like this one.
I'm curios if (at least) the discovery part can be automated...

Renovate has (experimental?) support for Nuget: https://renovatebot.com/docs/nuget/
cc @rarkins

@TravisEz13
Copy link
Member

@felixfbecker We can rarely take anything but revsion updates without making at least packaging changes (at least for windows). Can Renovate be configured to only take revision changes?

@felixfbecker
Copy link
Contributor

What is a revision update? I know you can configure it only update patch/minor/major versions with npm, but I haven't tried with nuget.

@TravisEz13
Copy link
Member

Yeah, I think Renovate/SemVer calls it patch. Sorry, I'm used to calling it revision. I found https://renovatebot.com/docs/configuration-options/#updatetypes, but I also found that it can create separate PRs for each type, which may be a better option.

@rarkins
Copy link

rarkins commented Sep 14, 2018

Currently Renovate classifies both patch version updates (e.g. 2.0.0 -> 2.0.1) as well as unstable bumps (e.g. 2.0.0-beta2 -> 2.0.0-beta3) as type "patch".

You could configure Renovate to either:

  1. Completely ignore minor or major updates (But then you might not even be aware they exist), or
  2. Always separate major/minor/patch updates so that you can quickly accept patch updates/revisions while taking longer on any minor/major.

@felixfbecker
Copy link
Contributor

Yeah usually you just let it open its PRs, if CI passes, you can merge directly (you can even configure Renovate to automerge if you are confident in your tests), if it doesn't, you can make manual edits on the branch before merging.

@rarkins
Copy link

rarkins commented Sep 14, 2018

I've enabled Renovate on a mirror of this repository so that you can see how it looks without needing to install it directly. Here's an example PR: https://github.com/renovate-mirrors/PowerShell/pull/2

@SteveL-MSFT SteveL-MSFT deleted the psreadline-beta3 branch September 14, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments