Add %F option to Get-Date -UFormat#7630
Add %F option to Get-Date -UFormat#7630iSazonov merged 1 commit intoPowerShell:masterfrom britishben:get-date-bpm
Conversation
iSazonov
left a comment
There was a problem hiding this comment.
@britishben Thanks for your contribution!
src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs
Outdated
Show resolved
Hide resolved
|
Thanks @chuanjiao10 - I've taken out the 'P' case now, so the only one of your cases this would solve is the first: Still, slow progress is better than no progress. |
|
@britishben If you don't plan fix %P please update the PR description and remove WIP. |
|
@iSazonov Done - thanks for the reminder. |
|
@britishben Please rebase to fix CIs. |
|
@iSazonov done, thanks - let me know if you need anything else from me. |
|
Please update package reference to Markdig.Signed 0.15.2 (see failed test)
|
|
@iSazonov I've bumped up the number in src/Microsoft.PowerShell.MarkdownRender/Microsoft.PowerShell.MarkdownRender.csproj to see if that makes a difference, but that's not my error; Looks like a version change from https://github.com/lunet-io/markdig/ (got 15.3, expected 15.2). You'll probably see the same on all your PRs. |
|
@britishben Yes, it is not your error. We have a test to check package versions. If there is a new version the test fail. We already merged a PR with version updates. So you should rebase. |
Update tests to add %F
|
@iSazonov Thanks - done that now. |
|
@anmenaga @TravisEz13 Please review the PR. |
|
@britishben Please open new issue in PowerSehll-Docs repo (or push PR there) to document the enhancement and add a link to the issue to the PR description. |
|
@britishben Thanks for your contribution! |
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
Documentation update for PowerShell/PowerShell#7630
PR Summary
I got annoyed that
Get-Date -UFormat '%F %T'did not work the same asdate +'%F %T', so I've added that case now. Partial fix for issue #7341.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests