Update .Net Core/SDK docs about version 2.0 to be about version 2.x#7467
Update .Net Core/SDK docs about version 2.0 to be about version 2.x#7467daxian-dbw merged 4 commits intoPowerShell:masterfrom
Conversation
|
there are spelling failures in travis-ci |
|
@TravisEz13 I addressed the spelling issues. |
| building on macOS is almost identical. | ||
|
|
||
| .NET Core 2.0 (and by transitivity, us) only supports macOS 10.12+. | ||
| .NET Core 2.x (and by transitivity, us) only supports macOS 10.12+. |
There was a problem hiding this comment.
Does the third bullet item also need to be changed?
Downloads and installs a preview version of .NET Core SDK 2.0 to ~/.dotnet
| @@ -171,7 +171,7 @@ can't find the `netstandard.dll` "implementation" assembly for the version of th | |||
|
|
|||
| ### The fix for missing netstandard.dll | |||
There was a problem hiding this comment.
There are stale references to 2.0 in this section. Two that stand out are
-
"Install the .NET Core SDK 2.0 for Windows, if it isn't already installed."
This actually links to the .NET Core 2.1 page. Perhaps updating the link label to also use 2.x -
Copy-Item 'C:\Program Files\dotnet\sdk\2.0.0\Microsoft...
A note about the version number varying might help so users arent' blindly copy/pasting the text and getting errors.
|
@dantraMSFT I pushed a commit to address your comments. Please take another look. |
|
@daxian-dbw Thanks for helping out, I was quite busy the last weeks due to moving house and forgot about this PR. |
|
@bergmeister No worries, that's what we maintainers do 😄 |
PR Summary
As per title. Due to the upgrade to .Net Core 2.1 in 6.1, it is better to not be specific about the version of .Net Core or the SDK.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests