Skip to content

Add script to create icns files.#7456

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
thezim:add-gen-icns
Jan 2, 2019
Merged

Add script to create icns files.#7456
TravisEz13 merged 2 commits intoPowerShell:masterfrom
thezim:add-gen-icns

Conversation

@thezim
Copy link
Contributor

@thezim thezim commented Aug 6, 2018

PR Summary

Add script to generate macOS icon file. It does not attempt to integrate with the current build process as the macOS icon file is mostly static.

libsvg was chosen because of its low dependency count over other solutions that use backends like Chromium, PhontomJS, etc. ImageMagick's convert was tested but resulting PNGs where not satisfactory and would have required an overcomplicated script having to calculate the density argument.

  • Has a dependency on librsvg (can be installed via Brew)
  • Uses SVG file as input
  • Can be integrated in later to build process if desired

Closes #7455

PR Checklist

@TravisEz13 TravisEz13 self-assigned this Aug 7, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Aug 7, 2018 •
edited
Loading

Does this need to be in our repo? This will take a significant about of time to review due to the use of librsvg. Just asking, I've already started the review.

@thezim
Copy link
Contributor Author

thezim commented Aug 7, 2018

@TravisEz13 The intent was to have the knowledge in this repo in case someone else needed to generate the icns files for the project due to an icon asset change.

@TravisEz13
Copy link
Member

TravisEz13 commented Aug 7, 2018

It's probably the right thing to do. The tool uses a GPL license and will take some time to get approval to use the tool.

@dantraMSFT dantraMSFT added the Review - Needed The PR is being reviewed label Aug 13, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Aug 20, 2018

Sorry, still waiting on the review here.

@stale
Copy link

stale bot commented Sep 19, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Sep 19, 2018
@anmenaga
Copy link

anmenaga commented Sep 19, 2018

@TravisEz13 how do we currently generate macOS icon file?

@stale stale bot removed the Stale label Sep 19, 2018
@thezim
Copy link
Contributor Author

thezim commented Sep 19, 2018 •
edited
Loading

@anmenaga I generated both of the current ones. This was a manual process. Export PNGs from the SVG to proper names and resolutions, then use iconutil to assemble the asset.

@TravisEz13
Copy link
Member

TravisEz13 commented Sep 19, 2018

Yup, I just checked the internal review and it is still ongoing.

@stale
Copy link

stale bot commented Oct 19, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Oct 19, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Oct 20, 2018

Sorry, still in review

@stale stale bot removed the Stale label Oct 20, 2018
@stale
Copy link

stale bot commented Nov 19, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Nov 19, 2018
@TravisEz13
Copy link
Member

TravisEz13 commented Nov 19, 2018

Sorry, still in review

@stale stale bot removed the Stale label Nov 19, 2018
@TravisEz13 TravisEz13 removed the Review - Needed The PR is being reviewed label Nov 19, 2018
@TravisEz13 TravisEz13 removed the request for review from dantraMSFT November 27, 2018 02:24
@TravisEz13
Copy link
Member

TravisEz13 commented Nov 27, 2018

@thezim could you push a new commit to update the CI status here? The internal review finally looks like it is finishing.

@thezim thezim requested a review from PaulHigin as a code owner November 29, 2018 20:21
@thezim
Copy link
Contributor Author

thezim commented Nov 29, 2018

@TravisEz13 done.

@stale
Copy link

stale bot commented Dec 30, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Dec 30, 2018
@stale stale bot removed the Stale label Jan 2, 2019
@TravisEz13 TravisEz13 merged commit 2a1b6ed into PowerShell:master Jan 2, 2019
@TravisEz13 TravisEz13 added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@TravisEz13 TravisEz13

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create automated way to create macOS icon.

4 participants

@thezim @TravisEz13 @anmenaga @dantraMSFT

Comments