Update comments to reflect the code - binary data is required.#7364
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Jul 25, 2018
dantraMSFT:dantra/issue7362
Merged
Update comments to reflect the code - binary data is required.#7364daxian-dbw merged 1 commit intoPowerShell:masterfrom dantraMSFT:dantra/issue7362
daxian-dbw merged 1 commit intoPowerShell:masterfrom
dantraMSFT:dantra/issue7362
Conversation
PaulHigin
approved these changes
Jul 25, 2018
daxian-dbw
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix: #7362
WSManReceiveDataResult.Unmarshal was incorrectly commented as requiring only text formatted data. In fact, it requires binary formatted data.
Both the method comment and the Dbg.Assert message have been updated. This change updates the text to avoid confusion reading the code.
Note the related issue in PSRP/Linux (PowerShell/psl-omi-provider#121)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests