Enable Get-ChildItem to produce Mode property even if cannot determine if hardlink#7355
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Jul 26, 2018
Merged
Conversation
… not to be defined
0d6d779 to
5943c51
Compare
Contributor
|
@SteveL-MSFT What will be the output after this change, will it exclude such files ? |
daxian-dbw
approved these changes
Jul 25, 2018
Member
Author
|
@kvprasoon no. With this change, it should work the same as with Windows PowerShell before we added the check for hard links. |
Member
|
@kvprasoon It will not exclude such files. The mode for such files will not have |
Contributor
|
@daxian-dbw Thanks for the clarification. |
iSazonov
approved these changes
Jul 25, 2018
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with one minor comment.
Collaborator
There was a problem hiding this comment.
We could remove if-s:
bool succeeded = InternalSymbolicLinkLinkCodeMethods.GetFileInformationByHandle(handle, out handleInfo);
return succeeded && (handleInfo.NumberOfLinks > 1);
Member
Author
There was a problem hiding this comment.
Good suggestion. Will update.
Member
|
@daxian-dbw FYI, I had to go back to the PR to figure this one out. The message used to commit wasn't as good as the PR title |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Some files in the user directory on Windows such as 'NTUSER.DAT' cause the IsHardLink() check to fail with an INVALID_HANDLE win32 error. This causes the
Modeproperty to fail being defined even though it was fine up until that last api call. I don't see any reason to throw an exception if the hard link check fails, instead just return false since we cannot determine it's a hardlink.Fix #7353
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests