Remove the 'VisualBasic' support from Add-Type#7284
Merged
adityapatwardhan merged 1 commit intoPowerShell:masterfrom Jul 13, 2018
Merged
Remove the 'VisualBasic' support from Add-Type#7284adityapatwardhan merged 1 commit intoPowerShell:masterfrom
adityapatwardhan merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Jul 13, 2018
Collaborator
|
There is one CodeFactor issue. |
Member
Author
|
@iSazonov The CodeFactor reports |
Collaborator
|
@daxian-dbw Seems we already fixed some such issues. Also as I meantioned I compiled CodeFormatter with latest Roslyn and open PR #7263 to show results. We could add new rules to CodeFormatter to fix some code issues. I think it's better for communities and the project. |
SteveL-MSFT
approved these changes
Jul 13, 2018
adityapatwardhan
approved these changes
Jul 13, 2018
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reference: #6141 (comment)
There was a discussion about whether
Add-Typeshould support Visual Basic, and the committee inclines to remove the Visual Basic support fromAdd-Typefor three reasons:Add-Typeis very rare (if there is any)Microsoft.CodeAnalysis.VisualBasic.dllThis PR is to remove the VB support from
Add-Type.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests