Fix condition syntax for StoreBroker package tasks in MSIX pipeline #26427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes condition syntax for two StoreBroker package tasks in the MSIX pipeline to use the correct OneBranch variable reference pattern, and adds a comprehensive instruction file documenting the proper OneBranch condition syntax for the repository.
Key Changes
- Updated StoreBroker package conditions from
'$(VARIABLE)'string expansion tovariables['VARIABLE']syntax - Added comprehensive OneBranch condition syntax instruction file with examples and best practices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.pipelines/templates/package-create-msix.yml |
Fixed condition syntax for Preview and Stable/LTS StoreBroker package tasks to use proper variables['NAME'] pattern |
.github/instructions/onebranch-condition-syntax.instructions.md |
Added comprehensive guide documenting correct OneBranch condition syntax with examples, troubleshooting tips, and best practices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daxian-dbw
approved these changes
Nov 12, 2025
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 12, 2025
5 tasks
adityapatwardhan
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Dec 2, 2025
9 tasks
SIRMARGIN
pushed a commit
to SIRMARGIN/PowerShell
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the condition syntax for StoreBroker package tasks in the MSIX pipeline to use proper OneBranch syntax.
The changes ensure that conditional expressions follow the correct OneBranch format for evaluating pipeline variables.