Skip to content

Fix NullReferenceException in CompleteFilename when called with empty string #26286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Fix NullReferenceException in CompleteFilename when called with empty string #26286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c74e3f2
Initial plan
Copilot Oct 23, 2025
c7a2270
Fix NullReferenceException in CompleteFilename and add test
Copilot Oct 23, 2025
459c0f3
Move CompleteFilename test from BugFix.Tests.ps1 to TabCompletion.Tes…
Copilot Oct 23, 2025
534098c
Remove comments from CompleteFilename test
Copilot Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4580,13 +4580,20 @@ internal static IEnumerable<CompletionResult> CompleteFilename(CompletionContext
return CommandCompletion.EmptyCompletionResult;
}

var lastAst = context.RelatedAsts[^1];
if (lastAst.Parent is UsingStatementAst usingStatement
&& usingStatement.UsingStatementKind is UsingStatementKind.Module or UsingStatementKind.Assembly
&& lastAst.Extent.File is not null)
if (context.RelatedAsts != null && context.RelatedAsts.Count > 0)
{
relativeBasePath = Directory.GetParent(lastAst.Extent.File).FullName;
_ = currentPS.AddParameter("RelativeBasePath", relativeBasePath);
var lastAst = context.RelatedAsts[^1];
if (lastAst.Parent is UsingStatementAst usingStatement
&& usingStatement.UsingStatementKind is UsingStatementKind.Module or UsingStatementKind.Assembly
&& lastAst.Extent.File is not null)
{
relativeBasePath = Directory.GetParent(lastAst.Extent.File).FullName;
_ = currentPS.AddParameter("RelativeBasePath", relativeBasePath);
}
else
{
relativeBasePath = context.ExecutionContext.SessionState.Internal.CurrentLocation.ProviderPath;
}
}
else
{
Expand Down
6 changes: 6 additions & 0 deletions test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4012,4 +4012,10 @@ Describe "WSMan Config Provider tab complete tests" -Tags Feature,RequireAdminOn
# https://github.com/PowerShell/PowerShell/issues/4744
# TODO: move to test cases above once working
}

It "[CompletionCompleters]::CompleteFilename should not throw NullReferenceException with empty string" {
{ [System.Management.Automation.CompletionCompleters]::CompleteFilename("") } | Should -Not -Throw
$result = [System.Management.Automation.CompletionCompleters]::CompleteFilename("")
$result | Should -Not -BeNullOrEmpty
}
}
Loading