Skip to content

Check for GetWindowPlacement success#26122

Merged
iSazonov merged 2 commits into
PowerShell:masterfrom
xtqqczze:GH6871
Oct 9, 2025
Merged

Check for GetWindowPlacement success#26122
iSazonov merged 2 commits into
PowerShell:masterfrom
xtqqczze:GH6871

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

Fix #6871

Comment thread test/powershell/Host/ConsoleHost.Tests.ps1 Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Review - Needed The PR is being reviewed label Oct 8, 2025
@iSazonov

iSazonov commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

@xtqqczze Please look CI error.

@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Review - Needed The PR is being reviewed label Oct 8, 2025
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Oct 9, 2025
@iSazonov iSazonov self-assigned this Oct 9, 2025

@iSazonov iSazonov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests don't fail now and we don't see the exception but it will be useful if this issue appears again. Now we can re-enable the tests.

/cc @daxian-dbw

@iSazonov

iSazonov commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run PowerShell-Windows-Packaging-CI, PowerShell-CI-linux-packaging

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@iSazonov iSazonov merged commit d581baa into PowerShell:master Oct 9, 2025
36 of 37 checks passed
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

📣 Hey @@xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@xtqqczze

xtqqczze commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

These tests don't fail now and we don't see the exception but it will be useful if this issue appears again. Now we can re-enable the tests.

/cc @daxian-dbw

The tests are still failing: #26123 (comment)

I don't understand how this is possible when they are marked pending.

@xtqqczze xtqqczze deleted the GH6871 branch October 9, 2025 12:53
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'WindowStyle argument' test in ConsoleHost.Tests.ps1 needs to check the return value the GetWindowPlacement interop call

2 participants