Update dotnetmetadata.json to accept .NET 7 preview 3 builds#17063
Merged
TravisEz13 merged 9 commits intoPowerShell:masterfrom Mar 25, 2022
Merged
Update dotnetmetadata.json to accept .NET 7 preview 3 builds#17063TravisEz13 merged 9 commits intoPowerShell:masterfrom
dotnetmetadata.json to accept .NET 7 preview 3 builds#17063TravisEz13 merged 9 commits intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Mar 25, 2022
| "nextChannel": "7.0.1xx-preview3", | ||
| "azureFeed": "", | ||
| "sdkImageOverride": "7.0.100-preview.2.22153.17" | ||
| "sdkImageOverride": "" |
Collaborator
There was a problem hiding this comment.
Why do we still need the same in global.json? Weird.
Member
Author
There was a problem hiding this comment.
This makes the GitHub workflow that updates the build stick to this specific version. If we keep this here, we will never get daily updates. The value is global.json is the one we are building against.
TravisEz13
approved these changes
Mar 25, 2022
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
dotnetmetadata.jsonto accept .NET 7 preview 3 nightly buildsMicrosoft.CSharpversion in Microsoft.PowerShell.NamedPipeConnection.csprojPR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).