Implement RFC 277: native error throwing#15897
Merged
daxian-dbw merged 47 commits intoPowerShell:masterfrom Aug 24, 2021
Merged
Implement RFC 277: native error throwing#15897daxian-dbw merged 47 commits intoPowerShell:masterfrom
daxian-dbw merged 47 commits intoPowerShell:masterfrom
Conversation
22 tasks
rkeithhill
reviewed
Aug 23, 2021
daxian-dbw
reviewed
Aug 23, 2021
daxian-dbw
requested changes
Aug 23, 2021
src/System.Management.Automation/engine/NativeCommandProcessor.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandProcessor.cs
Outdated
Show resolved
Hide resolved
daxian-dbw
approved these changes
Aug 24, 2021
iSazonov
reviewed
Aug 24, 2021
src/System.Management.Automation/engine/NativeCommandProcessor.cs
Outdated
Show resolved
Hide resolved
test/powershell/engine/Basic/NativeCommandErrorHandling.Tests.ps1
Outdated
Show resolved
Hide resolved
| continue | ||
| } | ||
|
|
||
| $hitTrap = $false |
Collaborator
There was a problem hiding this comment.
Should we explicitly create $exception in the scope too?
Collaborator
Author
There was a problem hiding this comment.
Well it'll be $null by default, rather than $false, so we don't really need to
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Sep 2, 2021
22 tasks
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Continuation of @rkeithhill's work in #15757.
Implements error throwing with error action preference integration for native executables, similar to
set -escenarios on *nix.PR Context
See on PowerShell/PowerShell-RFC#277.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.PSNativeCommandErrorActionPreference(which runs in a different PS Host).