Disable WMF link invocation test#13479
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Aug 19, 2020
PaulHigin:disable-link-check
Merged
Disable WMF link invocation test#13479daxian-dbw merged 1 commit intoPowerShell:masterfrom PaulHigin:disable-link-check
daxian-dbw merged 1 commit intoPowerShell:masterfrom
PaulHigin:disable-link-check
Conversation
daxian-dbw
approved these changes
Aug 18, 2020
Member
|
@TravisEz13, if the that WMF 4 link is not coming back, then we potentially need to change the link in the installer script. |
14 tasks
TravisEz13
reviewed
Aug 19, 2020
| ## We use a retry logic here. Retry for 5 times with 1 second interval. | ||
| It "Pre-Requisistes link for '<Name>' is reachable: <url>" -TestCases $linkCheckTestCases -Skip:$skipTest { | ||
| # It "Pre-Requisistes link for '<Name>' is reachable: <url>" -TestCases $linkCheckTestCases -Skip:$skipTest { | ||
| It "Pre-Requisistes link for '<Name>' is reachable: <url>" -TestCases $linkCheckTestCases -Pending { |
Member
There was a problem hiding this comment.
We should use Set-ItResult -Pending -Because 'link is broken'
Don't need to go back and fix it, but it allows you not to remove the skip code.
|
🎉 Handy links: |
rjmholt
pushed a commit
to rjmholt/PowerShell
that referenced
this pull request
Jan 12, 2021
# Conflicts: # test/powershell/Installer/WindowsInstaller.Tests.ps1
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR disables the WMF link invocation test in WindowsInstaller.Tests.ps1 file, by marking it 'pending'.
Issue #13478
PR Context
It seems like whether these links are currently working should not affect PowerShell build. If it is important to track aliveness of these links, I fee they should be performed in tests specifically for that and not appended to PowerShell build tests.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.