Add missing .editorconfig settings present in dotnet/runtime#12871
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Jun 30, 2020
Merged
Add missing .editorconfig settings present in dotnet/runtime#12871TravisEz13 merged 1 commit intoPowerShell:masterfrom
.editorconfig settings present in dotnet/runtime#12871TravisEz13 merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
Jun 3, 2020
This comment has been minimized.
This comment has been minimized.
iSazonov
approved these changes
Jun 4, 2020
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
|
@xtqqczze Please rebase to fix CI-static. |
2899921 to
0086e8c
Compare
Member
|
cc @daxian-dbw @adityapatwardhan Can you review? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Member
|
cc @daxian-dbw @adityapatwardhan Can you review? |
adityapatwardhan
approved these changes
Jun 22, 2020
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Contributor
Author
|
@daxian-dbw Can you please review? |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add settings from https://github.com/dotnet/runtime/blob/master/.editorconfig
We may want a different value for of the new settings, so please leave review comments,
PR Context
#7357
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.