This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Implemented getHeight and setHeight on AbstractButtonWidget#191
Merged
TheGlitch76 merged 2 commits intoPatchworkMC:masterfrom Sep 25, 2020
bs2kbs2k:feature/height-getter-setter-AbstractButtonWidget
Merged
Implemented getHeight and setHeight on AbstractButtonWidget#191TheGlitch76 merged 2 commits intoPatchworkMC:masterfrom bs2kbs2k:feature/height-getter-setter-AbstractButtonWidget
TheGlitch76 merged 2 commits intoPatchworkMC:masterfrom
bs2kbs2k:feature/height-getter-setter-AbstractButtonWidget
Conversation
| protected int height; | ||
|
|
||
| public int getHeight() { | ||
| return this.height; |
Contributor
There was a problem hiding this comment.
Can these just be Accessors?
Contributor
|
In the future, when Patchwork is complete, I want to be able to use some Forge things in my Fabric mods (aka make 🦆 interfaces please) |
YTG1234
approved these changes
Sep 16, 2020
Contributor
YTG1234
left a comment
There was a problem hiding this comment.
Other than that, looks good
TheGlitch76
approved these changes
Sep 25, 2020
Member
TheGlitch76
left a comment
There was a problem hiding this comment.
I'm 95% sure Mixin mangles accessors, so this is good how it is.
Thanks for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented https://github.com/PatchworkMC/YarnForge/blob/1.14.x/patches/minecraft/net/minecraft/client/gui/widget/AbstractButtonWidget.java.patch#L21
found on issue #125.
Change is very trivial and doesn't need testing.