This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
- Make some private static fields final - Remove an explicit generic type that was inferrable - Simplify logic in `unloadWorld` to mirror the logic in `getMinecraft` - Add javadoc for `unloadWorld`
- username -> profile (shouldn't break anything) - switch to using computeIfAbsent
TheGlitch76
approved these changes
Aug 17, 2020
Member
TheGlitch76
left a comment
There was a problem hiding this comment.
Looks good, just need to commit a couple small fixes myself and this will be merged.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off #77. Notable changes:
patchwork-fake-playersmoduleFakePlayerFactoryto make the code nicerfabric-lifecycle-events-v1instead offabric-events-lifecycle-v0