This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
TheGlitch76
reviewed
Aug 14, 2020
| * ChunkEvent is fired when an event involving a chunk occurs.<br> | ||
| * If a method utilizes this {@link net.minecraftforge.eventbus.api.Event} as | ||
| * its parameter, the method will receive every child event of this class.<br> | ||
| * <br> |
Member
There was a problem hiding this comment.
i think for now I'm not going to require changing the javadocs for Forge classes besides MCP-B-Gone because it just adds noise
TheGlitch76
suggested changes
Aug 14, 2020
patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEventsClient.java
Show resolved
Hide resolved
| * <br> | ||
| * This event is fired on the {@link MinecraftForge#EVENT_BUS}.<br> | ||
| */ | ||
| public static class Unload extends ChunkEvent { |
Member
There was a problem hiding this comment.
Seems like you forgot to implement the patch for this on the server?
Contributor
Author
There was a problem hiding this comment.
On the server side, it is fired here:
| * <br> | ||
| * This event is fired on the {@link MinecraftForge#EVENT_BUS}.<br> | ||
| */ | ||
| public static class Load extends ChunkEvent { |
Member
There was a problem hiding this comment.
This event is fired in two different spots in TACS, but you only fire it once here
Contributor
Author
There was a problem hiding this comment.
Server:
Client:
This should behaves exactly the same as Forge. I dont think i missed anything.
Member
There was a problem hiding this comment.
I missed this file! I marked it as "viewed" and glossed right over it
…t/world/WorldEventsClient.java Co-authored-by: Glitch <glitchieproductionsofficial@gmail.com>
TheGlitch76
approved these changes
Aug 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements ChunkEvent.Load and ChunkEvent.Unload events.
Most of these events are backed with the corresponding Fabric events, except for ChunkEvent.Load, which needs 1 extra mixin.