This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
Conflicts: patchwork-events-world/src/main/java/net/minecraftforge/event/world/BlockEvent.java patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEvents.java
Conflicts: patchwork-events-world/build.gradle patchwork-extensions-block/build.gradle
This removes a unnecessary dependency.
TheGlitch76
suggested changes
Aug 14, 2020
Member
TheGlitch76
left a comment
There was a problem hiding this comment.
Found an issue i missed the first time and then this LGTM
|
|
||
| import net.patchworkmc.impl.extensions.block.Signatures; | ||
|
|
||
| // This is a 1.15+ patch, should not be used in 1.14.4 |
Member
There was a problem hiding this comment.
Go ahead and just remove this.
| // Suppress this call | ||
| } | ||
|
|
||
| @Redirect(method = "tryBreakBlock", at = @At(value = "INVOKE", target = Signatures.ServerPlayerInteractionManager_isCreative, ordinal = 0)) |
Member
There was a problem hiding this comment.
I don't think this needs to be a redirect. One option could be to @slice from the isCreative check and inject at RETURN ordinal = 0.
Conflicts: patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEvents.java
Conflicts: patchwork-events-world/src/main/java/net/patchworkmc/impl/event/world/WorldEvents.java
TheGlitch76
approved these changes
Aug 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the malfunction 1.15 patch,
Move the BlockEvent from events-world to extensions-block, this can remove an unnecessary dependency, to make porting easier.