This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
TheGlitch76
reviewed
Aug 15, 2020
| ModLoadingContext.get().setActiveContainer(container, new FMLJavaModLoadingContext(container)); | ||
|
|
||
| try { | ||
| // container.setMod() |
Member
There was a problem hiding this comment.
is this meant to be uncommnented?
Contributor
Author
There was a problem hiding this comment.
This is just a reminder. We are supposed to record the mod instance here, but currently the interface exposed by our patcher does not return such instance. We can only have this after patcher is updated.
#119
PatchworkMC/patchwork-patcher#53
patchwork-dispatcher/src/main/resources/patchwork-dispatcher.mixins.json
Show resolved
Hide resolved
TheGlitch76
approved these changes
Aug 16, 2020
Member
TheGlitch76
left a comment
There was a problem hiding this comment.
This is a little odd but it's an improvement over what we had.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue mentioned in #111 and #119. Move the Forge mod construction code to the correct place. Fabric mods are constructed much earlier, fields required by some Forge mods aren't populated yet. For example, the custom model loader requires this to work. This pr also fix some issue in FMLServerStartingEvent and make it accommodate the new mod loading procedure.