This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
TheGlitch76
reviewed
Aug 5, 2020
Member
TheGlitch76
left a comment
There was a problem hiding this comment.
overall looks good, just some small nitpicks
| * @param type Subtype, can be null or "overlay" | ||
| * @return ResourceLocation pointing at the armor's texture | ||
| */ | ||
| public Identifier getArmorResource(Entity entity, ItemStack stack, EquipmentSlot slot, @Nullable String type) { |
Contributor
Author
There was a problem hiding this comment.
It is a forge callback, so I'm going to add it to an interface
| s1 = PatchworkArmorItemHandler.getArmorTexture(entity, stack, s1, slot, type); | ||
| Identifier resourcelocation = (Identifier) ARMOR_TEXTURE_CACHE.get(s1); | ||
|
|
||
| if (resourcelocation == null) { |
Contributor
Author
|
checkLicense failed due to |
Member
|
Merging with master should fix the license check. |
Member
|
Merge conflicts |
Conflicts: patchwork-god-classes/build.gradle patchwork-god-classes/src/main/resources/fabric.mod.json
Conflicts: patchwork-god-classes/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements callbacks in IForgeItem: