This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Add support for keybindings#154
Merged
TheGlitch76 merged 9 commits intoPatchworkMC:masterfrom Jul 30, 2020
snakefangox:feature/keybindings
Merged
Add support for keybindings#154TheGlitch76 merged 9 commits intoPatchworkMC:masterfrom snakefangox:feature/keybindings
TheGlitch76 merged 9 commits intoPatchworkMC:masterfrom
snakefangox:feature/keybindings
Conversation
added 3 commits
July 26, 2020 18:34
Cleaning up remaining absolute imports
Rongmario
reviewed
Jul 27, 2020
cittyinthecloud
suggested changes
Jul 27, 2020
Contributor
cittyinthecloud
left a comment
There was a problem hiding this comment.
assets.patchwork-key-bindings should also be assets/patchwork-key-bindings, but overall LGTM
patchwork-key-bindings/src/main/java/net/patchworkmc/mixin/keybindings/MixinKeybinding.java
Outdated
Show resolved
Hide resolved
Rongmario
previously requested changes
Jul 27, 2020
patchwork-key-bindings/src/main/java/net/patchworkmc/mixin/keybindings/MixinKeybinding.java
Show resolved
Hide resolved
patchwork-key-bindings/src/main/java/net/patchworkmc/mixin/keybindings/MixinKeybinding.java
Outdated
Show resolved
Hide resolved
rikka0w0
reviewed
Jul 27, 2020
...rk-key-bindings/src/main/java/net/patchworkmc/impl/keybindings/ForgeKeyBindingConstruct.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Have added some of the functionality. Namely that forge allows you to categorize key binds so they only fire in certain situations and not respecting that may have some weird side effects like jetpack mods working with your inventory open. Don't think it's too big a deal but it's a tiny change, sorry if this is bad form. |
TheGlitch76
approved these changes
Jul 29, 2020
patchwork-key-bindings/src/main/java/net/patchworkmc/mixin/keybindings/MixinKeyBinding.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Glitch <glitchieproductionsofficial@gmail.com>
"you can merge it, I only reviewed very minor stuff that was fixed early on"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new module to allow patchwork to support keybindings, this will prevent mods that use forge's special handling from crashing however it does not completely implement this special handling. The two additions in question are conflict handling and modifier key support. Because forge uses the default KeyBinding methods for this behavior this shouldn't cause any issues. I can make a follow up PR to add the complete API but these methods are not commonly used to begin with and I suspect this might be all that is needed. Additionally this method allows fabric mods that add these functions to support Patchwork mods.
I'm not sure about Patchwork naming conventions so better names are welcome.
This requires a Patcher PR, namely PatchworkMC/patchwork-patcher#67.