This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Use raw types to "hand erase" ExtendedForgeRegistryEntry's generics#151
Merged
coderbot16 merged 1 commit intomasterfrom Jul 25, 2020
Merged
Use raw types to "hand erase" ExtendedForgeRegistryEntry's generics#151coderbot16 merged 1 commit intomasterfrom
coderbot16 merged 1 commit intomasterfrom
Conversation
Member
|
watch as this breaks something else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "TNT Yeeter" edge case that #141 can't replicate correctly. Changes the ExtendedForgeRegistryEntry generic from
<V>to<V extends IForgeRegistryEntry<V>>, and converts all the Mixins to use raw types. I wrote a test mod and ran it over this and it was fine, but given how fragile replicating the ABI here has turned out to be, the more test cases the better.