This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Merged
Conversation
kitlith
reviewed
Jul 24, 2020
Comment on lines
+35
to
+37
| * <p>This event is cancellable. | ||
| * Canceling the event will cause the player to receive no items at all. | ||
| * The hook will still take the damage specified |
Contributor
There was a problem hiding this comment.
Suggested change
| * <p>This event is cancellable. | |
| * Canceling the event will cause the player to receive no items at all. | |
| * The hook will still take the damage specified | |
| * <p>This event is cancellable. | |
| * Canceling the event will cause the player to receive no items at all. | |
| * The hook will still take the damage specified</p> |
Contributor
|
Other than that single nit, looks solid. |
TheGlitch76
reviewed
Jul 26, 2020
...work-events-entity/src/main/java/net/minecraftforge/event/entity/player/ItemFishedEvent.java
Show resolved
Hide resolved
TheGlitch76
suggested changes
Jul 27, 2020
...events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinFishingBobberEntity.java
Show resolved
Hide resolved
...events-entity/src/main/java/net/patchworkmc/mixin/event/entity/MixinFishingBobberEntity.java
Show resolved
Hide resolved
…ature/itemfishedevent � Conflicts: � patchwork-events-entity/src/main/resources/patchwork-events-entity.mixins.json
TheGlitch76
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another event required by CoFH Core.