This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Change IForgeRegistryEntry.setRegistryName to return V, not IForgeRegistryEntry#131
Merged
TheGlitch76 merged 3 commits intomasterfrom Jul 21, 2020
Merged
Change IForgeRegistryEntry.setRegistryName to return V, not IForgeRegistryEntry#131TheGlitch76 merged 3 commits intomasterfrom
TheGlitch76 merged 3 commits intomasterfrom
Conversation
Contributor
|
LGTM once build and checkstyle are fixed. Would it be possible/sane to implement a version that returns V on top of a version that returns IForgeRegistryEntry? |
Member
|
in theory there could be a |
TheGlitch76
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the source and the bytecode return value match with Forge, and is required for CoFHCore to load correctly.