Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

ItemTooltipEvent#108

Merged
TheGlitch76 merged 3 commits intomasterfrom
feature/itemtooltipevent
Jul 19, 2020
Merged

ItemTooltipEvent#108
TheGlitch76 merged 3 commits intomasterfrom
feature/itemtooltipevent

Conversation

@cittyinthecloud
Copy link
Contributor

Completes a part of #84.

Copy link
Member

@TheGlitch76 TheGlitch76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style fixes


@Mixin(ItemStack.class)
public class MixinItemStack {
@Inject(method = "getTooltip", at = @At("RETURN"), locals = LocalCapture.PRINT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this can be removed?

"MixinClientPlayerEntity",
"MixinOtherClientPlayerEntity"
"MixinOtherClientPlayerEntity",
"MixinItemStack"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical order please

private final List<Text> toolTip;

/**
* This event is fired in {@link ItemStack#getTooltip(PlayerEntity, TooltipContext)}, which in turn is called from it's respective GUIContainer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCP name?

@TheGlitch76
Copy link
Member

Checkstyle needs fixed

@kitlith
Copy link
Contributor

kitlith commented Jul 19, 2020

CI seems to have failed due to a timeout when fetching from fabric's maven. Built locally, seems to be fine.

@TheGlitch76 TheGlitch76 merged commit 3f504ca into master Jul 19, 2020
@TheGlitch76 TheGlitch76 deleted the feature/itemtooltipevent branch July 19, 2020 19:11
@florensie
Copy link
Member

CI seems to have failed due to a timeout when fetching from fabric's maven. Built locally, seems to be fine.

You can manually trigger a re-run on the checks if this happens. ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants