Repository navigation
[feature] Randomize rating links - #253
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the rating prompt system to move channel labels from hardcoded resource files into a flexible configuration system. The changes introduce a configuration provider that loads rating prompt settings from JSON, supporting per-locale labels with culture fallback logic (exact culture → neutral culture → English → domain name). The PR maintains existing behavior where Store channels are shown for MSIX installations, while non-MSIX installations show AlwaysInclude channels plus randomized Additional channels.
Key changes:
- Introduced
RatingPromptConfigurationandRatingPromptConfigurationProviderto parse and validate rating prompt settings from configuration - Updated
RatingPromptServiceto use configuration-driven labels with culture fallback chain - Added comprehensive test coverage for configuration parsing and label resolution
- Removed obsolete rating channel entries from resource files
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/ByteSync.Client/Services/Ratings/RatingPromptService.cs |
Refactored to use configuration provider for channels, added label resolution with culture fallback and domain extraction logic |
src/ByteSync.Client/Services/Ratings/RatingPromptConfigurationProvider.cs |
New provider that parses RatingPrompt configuration section with validation and graceful fallbacks |
src/ByteSync.Client/Interfaces/Services/Ratings/RatingPromptConfiguration.cs |
New record types for rating prompt configuration model |
src/ByteSync.Client/Interfaces/Services/Ratings/IRatingPromptConfigurationProvider.cs |
New interface for configuration provider |
src/ByteSync.Client/local.settings.template.json |
Added RatingPrompt configuration schema with example structure |
tests/ByteSync.Client.UnitTests/Services/Ratings/RatingPromptServiceTests.cs |
Updated tests with configuration stub, added test for culture-based label resolution |
tests/ByteSync.Client.UnitTests/Services/Ratings/RatingPromptConfigurationProviderTests.cs |
New test suite for configuration parsing and validation logic |
src/ByteSync.Client/Assets/Resources/Resources.resx |
Removed channel-specific resource entries |
src/ByteSync.Client/Assets/Resources/Resources.fr.resx |
Removed channel-specific French resource entries |
src/ByteSync.Client/Assets/Resources/Resources.Designer.cs |
Removed generated code for deleted resource entries |
Files not reviewed (1)
- src/ByteSync.Client/Assets/Resources/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Implementation