Allow sessionrecording to write a file outside of user/recordings/#3150
Merged
Allow sessionrecording to write a file outside of user/recordings/#3150
Conversation
alexanderbock
approved these changes
Apr 2, 2024
WeirdRubberDuck
approved these changes
Apr 3, 2024
Co-authored-by: Alexander Bock <alexander.bock@liu.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can now specify a path with the intended filename when starting a recording. If no path is provided, the file is saved to user/recordings/.
This can be done from either the frontend UI or via
openspace.sessionRecording.startRecording.The path must be an absolute path to an existing directory in the filesytem, and the user must have write permissions to it.
The file would have to be played-back using
openspace.sessionRecording.startPlayback, becuase the UI only lists files that reside in the user/recordings/ directory.