Allow HystrixFeign.Builder to be used incrementally.#313
Allow HystrixFeign.Builder to be used incrementally.#313spencergibb wants to merge 1 commit intoOpenFeign:masterfrom
Conversation
There was a problem hiding this comment.
Because the change is in a terminal method you need it's original type 😞. One option is to move create a fallback() method which could retain the fluent style. Another is to create an AbstractBuilder<B> that returns B from each method allowing downstream builders to have custom terminal methods.
|
NetflixOSS » feign » feign-pull-requests #200 SUCCESS |
There was a problem hiding this comment.
Since the method can no longer be hidden, what do you think should be done here?
There was a problem hiding this comment.
unsupportedoperationexception
|
I had this in my intellij history, so yeah :P |
Uses covariant overrides so that those collecting Feign configuration via `Feign.Builder` can cast into `HystrixFeign.builder` to target an api. Closes #313
|
ps the feeling against a base |
Uses covariant overrides so that those collecting Feign configuration via `Feign.Builder` can cast into `HystrixFeign.builder` to target an api. Closes #313
No description provided.