Skip to content

"Standart" misspelling in BattleUnitAnimationPack and many other locations #1680

Description

@FilmBoy84

As detailed in #1677 and in relation to PR #1679

standart_animations, a BattleUnitAnimationPack member with around 200 uses across the animation pack code and the extractors, plus some prose in tools/extractors/docs/tactical.txt.

That one is not a cosmetic rename. The serialization codegen uses the name from gamestate_serialize.xml both as the generated C++ field name and as the literal save-file section key, so the string reaches disk as getSection("standart_animations"). Renaming it would orphan that section in every existing save unless a compatibility shim is added.

So it needs a decision rather than a patch: accept the save break, add a fallback that reads the old key, or leave the misspelling in place. Happy to file it as its own issue and implement whichever way you prefer, just did not want to bundle a save-compatibility change into a cosmetic rename.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Code QuerySomething doesn't seem right in the code. It may not be a bug, but it probably needs fixing!Further Information RequiredThis cannot currently be replicated - please provide more information and savegame examplesRoadmapA an issue containing features that need to be completed for a "full" gaming experience.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions