Testing behavior of IntrinsicProcessor#8
Open
jtulach wants to merge 2 commits intoObjectLayout:masterfrom
Open
Testing behavior of IntrinsicProcessor#8jtulach wants to merge 2 commits intoObjectLayout:masterfrom
jtulach wants to merge 2 commits intoObjectLayout:masterfrom
Conversation
…or of the annotation processor more deeply. To avoid own compilation error, we generate the META-INF/services registration dynamically using ServiceProvider annotation. The 'lookup' library which provides the annotation is used only during compilation (e.g. scope provided) then it is no longer needed.
…avac compilations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior of annotation processors gets more and more complicated over time. Detailed error detection and reporting needs to be properly tested. IntrinsicProcessor is currently not tested as all. I'd like to change that and offer the testing harness that worked quite well in many situations.
The first commit (6e9bcd7) turns on annotation processing for code src/test/java. This verifies that the annotation processor does not hiccup on valid test code.
The second commit (feb488f) introduces IntrinsicProcessorTest that checks an error is emitted when an intrinsic field is not final or private.