NuGet VSIX uses hybrid VisualStudio.Extensibility SDK and VSSDK to fix F5 Debugging Flakiness - #6982
Conversation
|
Back to draft. Need to move these to the Client project. |
7bb679c to
01fe535
Compare
martinrrm
left a comment
There was a problem hiding this comment.
Thanks for fixing! but how did you know what to add/change? Is there documentation?
I asked the VS Extensibility team, and they suggested I follow what the I did find a doc here if you'd like to reference it, https://learn.microsoft.com/en-us/visualstudio/extensibility/visualstudio.extensibility/get-started/in-proc-extensions?view=visualstudio |
| NuGet.Versioning.resources.dll | ||
|
|
||
| # 3rd party dlls to keep | ||
| Microsoft.Extensions.DependencyInjection.dll |
There was a problem hiding this comment.
Is this something needed for the VSIX start-up or what?
There was a problem hiding this comment.
When I check my VS install's PublicAssemblies directory, I see it in there. We don't need it for our msbuild tasks, so I believe we can remove it from our vsix to make the install size a bit smaller
There was a problem hiding this comment.
Good catch! #7007
I barely noticed a comment on this closed PR. In the future, please just message me directly if a post-merge question comes up. Thank you!
Bug
Fixes: NuGet/Home#14669
Description
SDK-style isn't fully supported for VS Extensibility by default. This PR moves us to a "hybrid" mode where we have both VSSDK and VisualStudio.Extensibility.
Once the 18.3 build tools are publicly available, NuGet.Client repo can move fully onto those.
In the meantime, I tested by changing a property in XAML, launching the VSIX in Experimental VS, and my change was available on the first try!
PR Checklist
Added tests- manually built and looked for change in Experimental VS InstanceLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.