J.S. Bach - Suite Anglaise IV (BWV809)#1115
J.S. Bach - Suite Anglaise IV (BWV809)#1115madrisan wants to merge 3 commits intoMutopiaProject:masterfrom
Conversation
|
Need to be updated to the latest version. |
|
Ok, found here. Can you add a commit to this PR to add the latest changes you made? |
|
Definitely yes, now that the MutopiaProject has been reborn :), I think I will invest some time in porting everything I have digitised over the past two years. |
|
Good to know you'll contribute again! I see that you work on CI/CD stuff... We definitely need a Github workflow setup for Mutopia to make PR reviews easier. I've started looking into mupub, but I'll need some help sooner or later. Mutopia provides PDF files in A4 and US Letter formats so you should check that your scores look good in these two formats. The tablet is not considered as a target device so if yours scores contain hacks for the tablet display I think you'd better remove them when you submit your scores to Mutopia. Don't know if I answered your question... |
|
There is no hack to enforce a 'tablet' format, but my scores are intended (optimised) for an A4 format. Regarding CI/CD, yes I can help I think even though I work in the GitLab environment at Qwant. |
|
Should be good for a merge now. |
ca73529 to
8999268
Compare
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
1ce6734 to
556997d
Compare
|
@fedelibre I'm testing GitHub Worlflows as a usable CI for this project. |
Ok, interesting. But I think that eventually we should use the same build tool used for the Mutopia website, that is mupub. It's not been developed for a while, but we are discussing some needed updates. |
|
Ok @fedelibre . My idea was to execute |
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
|
A CI with |
|
Thanks for your contribution. I don't have any experience with reviewing new Mutopia contributions, so I'm adding @dominicus in case he finds some time to give some feedback. These are my thoughts:
|
|
Hello, sorry for the delay. I was on holiday.
Why would a duplication of code be a good idea? The risk is that the various versions will not be synchronised.
This modularization is convenient for me
Two years ago I had taken a tour of the Mutopia partitions and found no common ground. I took my inspiration from what I found in some digitisations that I found better realised. For example the footer providing the licence. I am not so motivated to change the seventy or so digitisations I have in my pipe to merge into Mutopia. ;) |
It's just a simple single line, nothing complex. I would not call it a duplication. It's like a shebang in a bash or python file.
I'm Ok with the rest of what you wrote. |
|
@madrisan I see you added the \version statement in the parts/*.ly files, but you should add it to all the lilypond files in the parent folder. Thanks. |
… asked by the maintainer Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
@fedelibre I think adding a cover page is OK on a multi-movement piece, but I'm recommending we find an agreeable way to skip the reference to Blue Lavender Open Scores in the Mutopia PDFs. Perhaps @madrisan can add commented-out spacing code Mutopia maintainers can uncomment as we process the PRs. I'm not sure if I'm explaining this correctly, but there's ways to delineate code blocks so one can quickly spot code sections where you want to toggle comments to show/hide on this cover page. This way the project branding can show in Blue Lavender PDF, and be empty space in Mutopia PDF. I've added #1128 to discuss this topic of cover pages, URLs and capture feedback others have. |
Suite Anglaise n.4 for Piano by J.S. Bach (BWV809)