Conversation
waydabber
approved these changes
Aug 21, 2021
Member
Author
|
Just an FYI for the future, when merging, it's usually preferable to pick "Squash" merge (aka combine commits into one you can rename), however in this case it wasn't really necessary since it was just one commit :) |
Member
Author
|
If it's just one or two clean commits you can also pick Rebase merge, that just puts all the commits directly on top of master without merge commit, though I usually always squash. |
Member
|
Ok, I'll do that next time, sorry! :) This is only to make commit history nicer? |
Member
Author
|
No big deal 🙂 yeah it's mostly to make the history cleaner (easier to read changes) and to prevent random commits from polluting the history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently we forgot to change this 😅