Skip to content

Set archs to standard for releases#522

Merged
waydabber merged 1 commit intomasterfrom
fix/arch-settings
Aug 21, 2021
Merged

Set archs to standard for releases#522
waydabber merged 1 commit intomasterfrom
fix/arch-settings

Conversation

@JoniVR
Copy link
Member

@JoniVR JoniVR commented Aug 21, 2021

Apparently we forgot to change this 😅

@JoniVR JoniVR added the bug Issue is a bug (e.g. Crash, …) label Aug 21, 2021
@JoniVR JoniVR requested a review from waydabber August 21, 2021 13:09
@waydabber waydabber merged commit 8be0b86 into master Aug 21, 2021
@JoniVR
Copy link
Member Author

JoniVR commented Aug 21, 2021

Just an FYI for the future, when merging, it's usually preferable to pick "Squash" merge (aka combine commits into one you can rename), however in this case it wasn't really necessary since it was just one commit :)

@JoniVR JoniVR deleted the fix/arch-settings branch August 21, 2021 13:22
@JoniVR
Copy link
Member Author

JoniVR commented Aug 21, 2021

If it's just one or two clean commits you can also pick Rebase merge, that just puts all the commits directly on top of master without merge commit, though I usually always squash.

@waydabber
Copy link
Member

Ok, I'll do that next time, sorry! :) This is only to make commit history nicer?

@JoniVR
Copy link
Member Author

JoniVR commented Aug 21, 2021

No big deal 🙂 yeah it's mostly to make the history cleaner (easier to read changes) and to prevent random commits from polluting the history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is a bug (e.g. Crash, …)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants