Fix function keys not working and retry more often when getting values.#21
Merged
the0neyouseek merged 5 commits intoMonitorControl:masterfrom Mar 26, 2018
Conversation
Member
|
Hi @reitermarkus , Thanks for your PR, EDIT: I had a quick look and everything seems good. If it works I'll compile a new |
|
Function keys are still not working to me. Maybe because my keyboard is Bluetooth… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes function keys not working because displays aren't enabled by default, but only after unchecking and re-checking them in preferences.
Also I added a loop which tries more often to get the values from the display, since for me the default value of 10 tries in
ddcctldoes not work reliably. For me, the average is at about 200 tries, and can be up to 600 tries. And since this is only done once at launch, there shouldn't be any overhead afterwards.Fixes #13.