Skip to content

fix(installer): make link-only side-effect free - #58

Merged
Mohammed-Abdelhady merged 1 commit into
mainfrom
fix/installer-link-only-side-effects
Sep 7, 2026
Merged

Mohammed-Abdelhady merged 1 commit into
mainfrom
fix/installer-link-only-side-effects

Conversation

@Mohammed-Abdelhady

Copy link
Copy Markdown
Owner

What changed

  • keep ./install.sh --link-only from invoking native Claude or Codex plugin installation commands
  • preserve skill linking for detected OpenCode and Antigravity providers
  • add a regression test that fails if a native installer command is invoked
  • document the no-fetch, no-native-plugin behavior

Verification

  • npm run validate-plugin
  • npm run unittest
  • npm run evals
  • bash -n install.sh scripts/*.sh
  • git diff --check

Codex support remains preview and uncertified.

@Mohammed-Abdelhady
Mohammed-Abdelhady merged commit d84aa31 into main Sep 7, 2026
1 check passed
@Mohammed-Abdelhady
Mohammed-Abdelhady deleted the fix/installer-link-only-side-effects branch September 7, 2026 01:14
@Mohammed-Abdelhady

Copy link
Copy Markdown
Owner Author

PR #58 can no longer be reviewed under the skill workflow: it was merged during the review attempt.

Evidence from GitHub:

  • State: closed
  • Merged: true
  • Merged at: 2026-09-07T01:14:48Z
  • Merge commit: d84aa31afca147db5ee521bdd6ad63a01857330c
  • Head SHA: 864a04c6c8ac7a0f87aedd0478ef5dcb44829dff
  • GitHub Actions validation: successful

I did not post a starting comment or formal review because the PR was already merged, and the review rules prohibit reviewing closed or merged PRs. No repository files were modified, and I did not merge or push anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant