Conversation
Test Results367 tests 366 ✅ 1m 42s ⏱️ Results for commit 5cae18d. ♻️ This comment has been updated with latest results. |
andreleblanc11
requested changes
Sep 15, 2026
andreleblanc11
left a comment
Member
There was a problem hiding this comment.
I think the logic looks good. I just have one suggestion.
This change will make it so _tag_progress returns True on a successful operation and False on a failed operation. Could you please add a comment in the methods description to describe this change?
Also, adding unit tests is encouraged (for your case, you could add them in tests/sarracenia/sr_test.py). AI is pretty good at creating unit tests 🙂
Author
|
Updated the tag_progress method description and added tests for both altered fucntions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.