Patch #1760 - #1761
Merged
Merged
Patch #1760#1761
Conversation
andreleblanc11
requested review from
petersilva,
reidsunderland and
robjarawan
August 19, 2026 13:50
Test Results360 tests 359 ✅ 1m 42s ⏱️ Results for commit c888bfb. ♻️ This comment has been updated with latest results. |
reidsunderland
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1760
I moved all of the file descriptor closing logic into the condition that verifies the OS being ran is linux/unix.
I tested on my Windows system. Diff below shows pip3 package file on the left vs. sarracenia windows package file on right.
Windows installed sr3 package (patched) can run without crashing
Pip3 package still fails