Skip to content

Add missing string type hint to TransactionService::get() parameter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
r-brown merged 2 commits into from
Nov 15, 2025
Merged

Add missing string type hint to TransactionService::get() parameter #8

r-brown merged 2 commits into from
Nov 15, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 15, 2025 •
edited
Loading

Adds string type hint to the $number parameter in TransactionService::get() method for consistency with other service classes.

Changes

  • Added string type hint to $number parameter in TransactionService::get() (line 72)

This aligns with the pattern used in LicenseService::get(), ProductService::get(), LicenseeService::get(), and ProductModuleService::get():

// Before
public static function get(Context $context, $number): ?Transaction

// After
public static function get(Context $context, string $number): ?Transaction

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Nov 15, 2025
Merged
@r-brown
Add string type hint to TransactionService::get() $number parameter
4222978 
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 15, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/FakerPHP/Faker/zipball/e0ee18eb1e6dc3cda3ce9fd97e5a0689a88a64b5
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/Maks3w/xmldsig/zipball/e42980d022cede00f7ff34285e85db23cd89882a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-curl-class/php-curl-class/zipball/062f58613524947451efdb3dd7d7217719670a9f
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/robrichards/xmlseclibs/zipball/2bdfd742624d739dfadbd415f00181b4a77aaf07
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/code-unit-reverse-lookup/zipball/5e3a687f7d8ae33fb362c5c0743794bbb2420a1d
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/comparator/zipball/e8e53097718d2b53cfb2aa859b06a41abf58c62e
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/diff/zipball/c41e007b4b62af48218231d6c2275e4c9b975b2e
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/environment/zipball/8074dbcd93529b357029f5cc5058fd3e43666984
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/exporter/zipball/0735b90f4da94969541dac1da743446e276defa6
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/global-state/zipball/987bafff24ecc4c9ac418cab1145b96dd6e9cbd9
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/202d0e344a580d7f7d04b3fafce6933e59dae906
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/24ed13d98130f0e7122df55d06c5c4942a577957
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/7e308268858ed6baedc8704a304727d20bc07c77
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/phpunit/zipball/e24fb46da450d8e6a5788670513c1af1424f16ca
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/47e34210757a2f37a97dcd207d032e1b01e64c7a
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/462699a16464c3944eefc02ebdd77882bd3925bf
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/c51fa83a5d8f43f1402e3f32a005e6262244ef17
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)
  • https://api.github.com/repos/wp-cli/php-cli-tools/zipball/f12b650d3738e471baed6dd47982d53c5c0ab1c3
    • Triggering command: /usr/bin/php8.3 -n -c /tmp/4bRZgH /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] WIP address feedback on PHP stack upgrade pull request Add missing string type hint to TransactionService::get() parameter Nov 15, 2025
Copilot AI requested a review from r-brown November 15, 2025 09:06
@r-brown r-brown marked this pull request as ready for review November 15, 2025 09:08
@r-brown r-brown merged commit 1e1bd59 into feature/AAV/upgrade-php-stack Nov 15, 2025
6 checks passed
@r-brown r-brown deleted the copilot/sub-pr-7 branch November 15, 2025 09:08
r-brown added a commit that referenced this pull request Nov 15, 2025
@r-brown
Upgrade PHP stack (#7)
c2b2ead 
* Upgrade NetLicensingClient-php library to support PHP v8.2 and higher

* Fix demo

* Fix security warnings

* Revisit GitHub Actions

* Prepare v2.6.0

* Copilot review

* Add missing string type hint to TransactionService::get() parameter (#8)

* Initial plan

* Add string type hint to TransactionService::get() $number parameter

Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

* Add string type hint to PaymentMethodService::get() parameter (#9)

* Initial plan

* Add string type hint to PaymentMethodService::get() $number parameter

Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: r-brown <1361258+r-brown@users.noreply.github.com>

* Update vo/ValidationParameters.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@r-brown r-brown r-brown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@r-brown r-brown

Copilot code review Copilot

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-brown