Fix title case of non-English items for all variables (fix #251)#264
Open
zepinglee wants to merge 1 commit into
Open
Fix title case of non-English items for all variables (fix #251)#264zepinglee wants to merge 1 commit into
zepinglee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSL spec says that title case conversion should be skipped for non-English items.
In citeproc-js, the checking English language with
text-case="title"isonly applied to variables in
CSL.MULTI_FIELDS, which results in the non-English value ofvolume-titlebeing incorrectly converted to title case (#251). In PR #253 and #259, more variables were added to
CSL.MULTI_FIELDS, yet there are still problems.cslrun -a --reporter spec). This is because two number variables (editionandvolume) which should not be processed along with the title variables were mistakenly added toCSL.MULTI_FIELDS.cs:date,cs:date-part,cs:label,cs:name-part,cs:number, andcs:textelements.This PR removes
editionandvolumevariables fromCSL.MULTI_FIELDSand adds checking for non-English title case conversion in all possible elements.The current test result