Skip to content

Get test suite passing tests again#389

Open
quinnj wants to merge 5 commits into
mainfrom
jq/testsfix
Open

Get test suite passing tests again#389
quinnj wants to merge 5 commits into
mainfrom
jq/testsfix

Conversation

@quinnj

@quinnj quinnj commented Apr 1, 2021

Copy link
Copy Markdown
Member

No description provided.

@quinnj

quinnj commented Apr 1, 2021

Copy link
Copy Markdown
Member Author

cc: @jpsamaroo , this needs JuliaParallel/Dagger.jl#208 to pass

@quinnj

quinnj commented Apr 2, 2021

Copy link
Copy Markdown
Member Author

Ah, looks like we have some Julia 1.0 compatibility issues here w/ the reduce stuff. Ugh.

@jpsamaroo

Copy link
Copy Markdown
Collaborator

Just drop support for <1.3? 1.0 users probably won't be able to get recent versions of various packages anyway. Once 1.7 is released, I'm going to lower-bound Julia to at least 1.3 in Dagger.

@quinnj

quinnj commented Apr 7, 2021

Copy link
Copy Markdown
Member Author

Yeah, good idea; just pushed that, let's see what CI thinks.

@zsz00

zsz00 commented Jun 26, 2021

Copy link
Copy Markdown

How is it going now?

@XinyuWuu

Copy link
Copy Markdown

#384

@XinyuWuu XinyuWuu mentioned this pull request Aug 18, 2021
@andreasnoack andreasnoack reopened this Sep 3, 2021
matteorossini added a commit to Electa-Git/FlexPlan.jl that referenced this pull request Mar 24, 2022
This commit deletes:
- code that depends on JuliaDB;
- code related to reliability analysis;
- code that is no longer used after previous deletions.

JuliaDB is basically unmaintained (latest release is one year and a half ago; multiple blocking issues refer to <JuliaData/JuliaDB.jl#389> which is stale) and cannot be used together with the other dependencies due to unsatisfiable version requirements. Substituting JuliaDB with DataFrames would entail a complete rewrite in most cases.

The code related to reliability analysis has not kept up with the updates made in the repository in the last year (such as adding dimensions, new problem functions, investment constraints specified only once a year rather than for all hours...).

Any code deleted here can of course be restored when someone is willing to update it.
Heptazhou pushed a commit to Heptazhou/JLdb.jl that referenced this pull request Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants