Merge pull request webpack#6645 from zacanger/fix/6644

sokra · web-flow · commit 00f70fc65cab · 2018-03-03T18:00:15.000+01:00
Fix webpack#6644
diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js
@@ -83,7 +83,7 @@ module.exports = class SplitChunksPlugin {
 		this.options = SplitChunksPlugin.normalizeOptions(options);
 	}
 
-	static normalizeOptions(options) {
+	static normalizeOptions(options = {}) {
 		return {
 			chunks: options.chunks || "all",
 			minSize: options.minSize || 0,
diff --git a/test/configCases/split-chunks/no-options/a.js b/test/configCases/split-chunks/no-options/a.js
@@ -0,0 +1 @@
+module.exports = "a";
diff --git a/test/configCases/split-chunks/no-options/index.js b/test/configCases/split-chunks/no-options/index.js
@@ -0,0 +1,6 @@
+require("should");
+
+it("should run", function() {
+	var a = require("./a");
+	a.should.be.eql("a");
+});
diff --git a/test/configCases/split-chunks/no-options/test.config.js b/test/configCases/split-chunks/no-options/test.config.js
@@ -0,0 +1,5 @@
+module.exports = {
+	findBundle: function(i, options) {
+		return ["vendor.js", "main.js"];
+	}
+};
diff --git a/test/configCases/split-chunks/no-options/webpack.config.js b/test/configCases/split-chunks/no-options/webpack.config.js
@@ -0,0 +1,16 @@
+const SplitChunksPlugin = require("../../../../lib/optimize/SplitChunksPlugin");
+
+module.exports = {
+	entry: {
+		vendor: ["./a"],
+		main: "./index"
+	},
+	target: "web",
+	output: {
+		filename: "[name].js"
+	},
+	optimization: {
+		splitChunks: false
+	},
+	plugins: [new SplitChunksPlugin()]
+};

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ module.exports = class SplitChunksPlugin {`
`83`	`83`	`this.options = SplitChunksPlugin.normalizeOptions(options);`
`84`	`84`	`}`
`85`	`85`
`86`		`- static normalizeOptions(options) {`
	`86`	`+ static normalizeOptions(options = {}) {`
`87`	`87`	`return {`
`88`	`88`	`chunks: options.chunks \|\| "all",`
`89`	`89`	`minSize: options.minSize \|\| 0,`