Fix temporaryDeploymentBranch conflict by replacing slash with hyphen #1892
+827
−909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a Git reference conflict that occurs when creating temporary deployment branches. The action was failing when a branch named
github-pages-deploy-actionalready exists in the repository.The action creates temporary branches using the pattern:
When a branch named
github-pages-deploy-actionalready exists, Git cannot create the temporary branch because it interprets branch names with forward slashes as nested references. This causes the error:Changed the temporary branch naming pattern from:
`github-pages-deploy-action/${randomString}`To:
`github-pages-deploy-action-${randomString}`This uses a hyphen separator instead of a forward slash, eliminating the Git reference conflict while maintaining a clear naming convention.
Changes Made
temporaryDeploymentBranchTesting Instructions
yarn test- All 60 tests should pass including the new test that validates temporary branch names use hyphensyarn build- Should complete without errorsyarn lint- Should pass without issuesAdditional Notes
This minimal change resolves the Git reference conflict without affecting any other functionality or breaking existing workflows. The addition of Copilot instructions will help improve future development and contributions to the repository.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.